Re: [PATCH 2/2] introduce I_SYNC

From: JÃrn Engel
Date: Tue May 08 2007 - 08:07:51 EST


On Tue, 8 May 2007 09:23:48 +0200, Thomas Gleixner wrote:
> On Tue, 2007-05-08 at 00:01 +0200, JÃrn Engel wrote:
> > This patch is actually independent of LogFS. It fixes a deadlock
> > hidden in fs/fs-writeback.c that LogFS was unlucky enough to trigger.
> > I strongly suspect NTFS triggered the same deadlock and "solved" it by
> > introducing iget5_nowait(). For LogFS, iget5_nowait() would translate
> > the deadlock into data corruption, so that is not an option.
>
> Have you talked to NTFS folks about that ?

Anton was on Cc: when I sent the first round of this patch. He didn't
respond.

> If it is a general problem, then please seperate the patch from logfs.

The problem certainly is generic and the patch already seperate. I can
resend it in a seperate thread if that is preferred.

Until yesterday it appeared as if LogFS was the only code that could
trigger the problem. NTFS is hard to judge without maintainer comment.
By now it appears as if JFS and NFS have joined in. Maybe I was
over-cautious in not sending it for some month.

JÃrn

--
He that composes himself is wiser than he that composes a book.
-- B. Franklin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/