Re: Please revert 86c0baf123e474b6eb404798926ecf62b426bf3a

From: Prarit Bhargava
Date: Tue May 08 2007 - 10:07:48 EST




Russell King wrote:
The change:

+#ifdef CONFIG_HOTPLUG_CPU
+#define __INIT .section ".text","ax"
+#define __INITDATA .section ".data","aw"
+#else
#define __INIT .section ".init.text","ax"
-#define __FINIT .previous
#define __INITDATA .section ".init.data","aw"
+#endif
+#define __FINIT .previous


Something is not right here.... was this the patch that I submitted? If so then I definitely screwed up pretty badly.

I thought I had done (sorry for the cut-and-paste):


+#ifdef CONFIG_HOTPLUG_CPU
+#define __CPUINIT .section ".text","ax"
+#define __CPUINITDATA .section ".data","aw"
+#else
+#define __CPUINIT __INIT
+#define __CPUINITDATA __INITDATA
+#endif


Maybe some wires got crossed along the submit route... Russell, I'll submit a fix against the latest tree.

P.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/