Re: [PATCH 3/3] [POWERPC] dts: kill hardcoded phandles

From: Vitaly Bordug
Date: Tue May 08 2007 - 12:27:09 EST


On Tue, 8 May 2007 07:29:20 -0700
"Loeliger Jon-LOELIGER" <jdl@xxxxxxxxxxxxx> wrote:

>
> > > - interrupt-controller@f8200000 {
> > > - linux,phandle = <f8200000>;
> > > + pci_pic:interrupt-controller@f8200000 {
> >
> > I'd like to establish a convention of putting a space after the : and
> > using capitals for labels unless there's a strong reason not to in a
> > particular case. It makes them easier to visually distinguish next to
> > the node name.
>
> Colon-space is easy and I'll buy it.
> I'm not big on uppercase shouting, though.
>
> Perhaps something more like case or goto labels:?
>
> pci_pic:
> interrupt-contoller@f8200000 {
>
> if needed?
>
I used middle solution
Pci_pic: interrupt-contoller@f8200000 {
so first letter of the label should be uppercase.
It makes them easily distinguishable and at the same time, not "shouting" manner.


--
Sincerely,
Vitaly
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/