RE: [PATCH 1/3] kbuild: complain about missing system calls.

From: Luck, Tony
Date: Tue May 08 2007 - 14:35:52 EST


Looks more complex than necessary. Why do you want to execute
an arch specific script to list the __IGNORE symbols? That would
allow an arch to generate a list with sed/perl/etc. but that
looks like overkill.

If you just have an arch specific file with the right defines.
E.g. for x86_64 in include/asm-x86_64/ignore_syscalls:

#include __IGNORE_getcpu

Then the checksyscalls.sh changes would just be something like
(do I need a ${srctree} before the include??):

diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
index f98171f..616f7c5 100755
--- a/scripts/checksyscalls.sh
+++ b/scripts/checksyscalls.sh
@@ -105,6 +105,10 @@ cat << EOF
#define __IGNORE_putpmsg
#define __IGNORE_vserver
EOF
+if [ -f include/asm/ignore_syscalls ]
+then
+ cat include/asm/ignore_syscalls
+fi
}

syscall_list() {

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/