Re: [patch 2/4] add argv_split()

[Jeremy Fitzhardinge]

Jan Engelhardt wrote:
> On May 8 2007 13:51, Jeremy Fitzhardinge wrote:
>   
>> +
>> +static const char *skip_sep(const char *cp)
>>     
>
> These are so simple they could use an 'inline' tag.
>   

I'm sure the compiler can work that out for itself.

>> +#ifdef TEST
>>     
>
> But not in the end result.
>   

?

>> +int main() {
>> +	const char *testvec[] = {
>>     
>
> Suggesting static const char *const testvec[].
>   

I guess, but it doesn't matter much.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/