Re: CodingStyle: start flamewar about use of braces

[Stephen Clark]

Lennart Sorensen wrote:

> On Tue, May 08, 2007 at 05:19:45PM -0400, Jeff Garzik wrote:
>  
>
> > > > +Do not unnecessarily use braces where a single statement will do.
> > > > +
> > > > +if (condition)
> > > > +	action();
> > > > +
> > > > +This does not apply if one branch of a conditional statement is a single
> > > > +statement. Use braces in both branches.
> > > > +
> > > > +if (condition) {
> > > > +	do_this();
> > > > +	do_that();
> > > > +} else {
> > > > +	otherwise();
> > > > +}
> > > >        
> > If anyone tries to add braces to my code's 'else' statements where they 
> > are not required, that patch will get NAK'd in a heartbeat.
> >    
>
> Oh isn't coding style fun.  I personally hate code that doesn't ALWAYS
> have the braces everywhere since it makes adding a print statement
> or other debuging to the condition such a pain since you then have to
> add braces to the condition to avoid breaking the code just to insert
> a print statement.  It is one of the few things I disagree with in the
> linux kernel coding style.
>
> --
> Len Sorensen
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>  
I agree - it is merely defensive programming to always have the braces, 
it prevents someone
from sticking in a diag and forgetting to add braces so things go haywire.

My $.02
Steve

--

"They that give up essential liberty to obtain temporary safety, 
deserve neither liberty nor safety."  (Ben Franklin)

"The course of history shows that as a government grows, liberty 
decreases."  (Thomas Jefferson)



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/