Re: [PATCH 3/3] [POWERPC] dts: kill hardcoded phandles

[David Gibson]

On Tue, May 08, 2007 at 08:26:08PM +0400, Vitaly Bordug wrote:
> On Tue, 8 May 2007 07:29:20 -0700
> "Loeliger Jon-LOELIGER" <jdl@xxxxxxxxxxxxx> wrote:
> 
> > 
> > > > -       interrupt-controller@f8200000 {
> > > > -               linux,phandle = <f8200000>;
> > > > +		pci_pic:interrupt-controller@f8200000 {
> > > 
> > > I'd like to establish a convention of putting a space after the : and
> > > using capitals for labels unless there's a strong reason not to in a
> > > particular case.  It makes them easier to visually distinguish next to
> > > the node name.
> > 
> > Colon-space is easy and I'll buy it.
> > I'm not big on uppercase shouting, though.
> > 
> > Perhaps something more like case or goto labels:?
> > 
> >     pci_pic:
> >         interrupt-contoller@f8200000 {
> > 
> > if needed?
> > 
> I used middle solution 
> 	Pci_pic: interrupt-contoller@f8200000 {
> so first letter of the label should be uppercase.

Ick, I preferred the original lowercase.

> It makes them easily distinguishable and at the same time, not
> "shouting" manner.

I don't think it really does make them distinguishable (I'm talking
about seeing them when glancing over a screenful of dts, not just up
close).

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/