Re: [PATCH] change zonelist order v5 [1/3] implements zonelistorder selection

[Lee Schermerhorn]

On Wed, 2007-05-09 at 10:20 +0900, KAMEZAWA Hiroyuki wrote:
> On Tue, 8 May 2007 17:58:55 -0700
> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Wed, 9 May 2007 09:29:12 +0900
> > KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> > 
> > > On Tue, 08 May 2007 16:37:06 -0400
> > > Lee Schermerhorn <Lee.Schermerhorn@xxxxxx> wrote:
> > > 
> > > > > You probably need a 
> > > > > configuration with a couple of nodes. Maybesomething less symmetric than 
> > > > > Kame? I.e. have 4GB nodes and then DMA32 takes out a sizeable chunk of it?
> > > > > 
> > > > 
> > > > I tested on a 2 socket, 4GB Opteron blade.  All memory is either DMA32
> > > > or DMA.  I added some ad hoc instrumentation to the build_zonelist_*
> > > > functions to see what's happening.  I have verified that the patches
> > > > appear to build the zonelists correctly:
> > > > 
> > > Thank you. good news.
> > > 
> > 
> > I'm still cowering in fear of these patches, btw.
> > 
> Hmm, the patches looks unclear ? 
> 
> > Please keep testing and sending them ;)
> > 
> Okay. but it seems I need other testers...
> 
> I wonder I should drop sysctl of this patch and just support boot option
> in next version.

I think the system still need to be able to rebuild the zonelists at
run-time in response to memory hotplug [someday, maybe?].  And for now,
the sysctl is very useful for testing.  And, it does avoid a
reboot--quite expensive, timewise, on large platforms--should one find
that the default order is not appropriate.  

Lee

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/