Re: [PATCH 7/12] i386 sg: add support for chaining scatterlists

From: Satyam Sharma
Date: Thu May 10 2007 - 09:23:40 EST


On 5/10/07, Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:
[...]
+static inline void sg_chain(struct scatterlist *prv, unsigned int prv_nents,
+ struct scatterlist *sgl)
+{
+#ifndef ARCH_HAS_SG_CHAIN
+ BUG();
+#endif

Hmmm ... so we better also make sure all users call this from within
an "#ifdef ARCH_HAS_SG_CHAIN" themselves (or else make this a config
option defined in the arch/.../defconfig of archs that support this
and then make the calling code's Kconfig option "depends on ... &&
ARCH_FOO").

(Just saw a previous thread, Andrew seems to have beaten me to this observation)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/