Re: [PATCH/RFC] Fix build failure for drivers/ata/pata_scc.c

[Tejun Heo]

Tony Breeds wrote:
> The commit d4b2bab4f26345ea1803feb23ea92fbe3f6b77bc added deadline support to
> prereset and reset methods to libbata the pata_scc driver wasn't converted.
> This patch is a naive attempt to bring this driver up to scratch.
> 
> Build failures are:
> drivers/ata/pata_scc.c: In function 'scc_pata_prereset':
> drivers/ata/pata_scc.c:870: error: too few arguments to function 'ata_std_prereset'
> drivers/ata/pata_scc.c: In function 'scc_error_handler':
> drivers/ata/pata_scc.c:916: warning: passing argument 2 of 'ata_bmdma_drive_eh' from incompatible pointer type
> drivers/ata/pata_scc.c:916: warning: passing argument 3 of 'ata_bmdma_drive_eh' from incompatible pointer type
> drivers/ata/pata_scc.c: In function 'scc_pata_prereset':
> drivers/ata/pata_scc.c:871: warning: control reaches end of non-void function
> 
> On a releated note scc_bus_post_reset() is (AFACT) identical to
> ata_bus_post_reset(), would a patch to make ata_bus_post_reset() assesable to
> drivers be accepted?
> 
> 
> Signed-off-by: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
> CC: Tejun Heo <htejun@xxxxxxxxx>
> CC: Akira Iguchi <akira2.iguchi@xxxxxxxxxxxxx>
> CC: Jeff Garzik <jgarzik@xxxxxxxxx>
> CC: linux-ide@xxxxxxxxxxxxxxx

Acked-by: Tejun Heo <htejun@xxxxxxxxx>

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/