Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

[Herbert Xu]

Benny Halevy <bhalevy@xxxxxxxxxxx> wrote:
>
> I was trying to say that the methods should be compatible, otherwise
> bugs can happen, and that your scheme is better since it can
> handle sglists with zero length entries that aren't the last.
> A case that might be valid after dma mapping and merging.
> If indeed this case is possible, this seems to be the right time
> to converge to your scheme.

Well right now this isn't possible because the crypto layer is not
directly hooked to any DMA code since it's (mostly) software only.

However, I completely agree that it should be converted to this new
scheme.  The only user of chaining right now is crypto/hmac.c so it
should be easy to fix.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/