Re: [PATCH] libata: fallback to the other IDENTIFY on device error,take#2

From: Tejun Heo
Date: Sun May 13 2007 - 08:59:22 EST


Jeff Garzik wrote:
> Tejun Heo wrote:
>> + if (class == ATA_DEV_ATA)
>> + class = ATA_DEV_ATAPI;
>> + else
>> + class = ATA_DEV_ATA;
>
>
> the 'else' branch is obviously redundant

Why? We can also fallback from ATAPI to ATA.

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/