Re: why does x86 "make defconfig" build a single, lonely module?

[James Bottomley]

On Sun, 2007-05-13 at 12:06 -0400, Dave Jones wrote:
> On Sun, May 13, 2007 at 11:22:55AM -0400, Robert P. J. Day wrote:
>  > 
>  >   not a big deal, but is there a reason that a "make defconfig" on my
>  > x86 system ends up selecting and building a single module?
>  > 
>  >   Building modules, stage 2.
>  >   MODPOST 1 modules
>  >   CC      drivers/scsi/scsi_wait_scan.mod.o
>  >   LD [M]  drivers/scsi/scsi_wait_scan.ko
>  > 
>  > is there something special about that module?  just curious.
> 
> My guess is that someone was paranoid and wanted not to have
> to answer a zillion "my machine won't boot any more" questions
> when async scsi scanning was added.
> This might further clarify..
> 
> ---
> 
> The scsi_wait_scan module is only really useful if async scanning
> is enabled.
> 
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
> 
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index e62d23f..0f6c370 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -244,7 +244,7 @@ config SCSI_SCAN_ASYNC
>  config SCSI_WAIT_SCAN
>  	tristate
>  	default m
> -	depends on SCSI
> +	depends on SCSI_SCAN_ASYNC

No.  SCSI_SCAN_ASYNC is a bool ... if you depend on it, you'll force the
wait scan to be built in, which isn't the idea at all.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/