Re: [PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t

From: Christoph Hellwig
Date: Sun May 13 2007 - 17:46:33 EST


On Sat, May 12, 2007 at 09:31:05AM -0500, Olof Johansson wrote:
> ppc64 really needs ioaddr_t to be 64-bit, since I/O addresses really
> are MMIO addresses, and remapped to a high range.
>
> While the type is exported to userspace, there hasn't been any platforms
> with PCMCIA on 64-bit powerpc until now, so changing it won't regress
> any existing users.

In fact the only use of the type should be in the obsolete ioctl-based user
interface. So instead of changing the size of the type you should

a) make sure you're not using cardmgr
b) fix up those places that still use ioaddr_t where they shouldn't
and switch the to kio_addr_t (why not just unsigned long like all
other busses?)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/