Re: [RFC][PATCH 14/14] tmpfs whiteout support

From: Jan Blunck
Date: Mon May 14 2007 - 15:21:08 EST


On 5/14/07, Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
On Mon, 14 May 2007, Bharata B Rao wrote:
> From: Jan Blunck <j.blunck@xxxxxxxxxxxxx>
> Subject: tmpfs whiteout support
>
> Introduce whiteout support to tmpfs.
>
> Signed-off-by: Jan Blunck <j.blunck@xxxxxxxxxxxxx>
> Signed-off-by: Bharata B Rao <bharata@xxxxxxxxxxxxxxxxxx>
> ---
> mm/shmem.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletion(-)
>
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -74,7 +74,7 @@
> #define LATENCY_LIMIT 64
>
> /* Pretend that each entry is of this size in directory's i_size */
> -#define BOGO_DIRENT_SIZE 20
> +#define BOGO_DIRENT_SIZE 1

Why would that change be needed for whiteout support?


Good question. It seems that this a survivor of the changes necessary
for union readdir. This isn't necessary for white-outs.

BTW: Why do we claim this to be 20??? Is there any meaning behind this?

Cheers,
Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/