Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

From: Andrew Morton
Date: Mon May 14 2007 - 17:21:49 EST


On Wed, 09 May 2007 02:31:25 +0400
Vitaly Bordug <vitb@xxxxxxxxxxxxxxxxxxx> wrote:

> +/*
> + * Some internal interrupt registers use an 8-bit mask for the interrupt
> + * level instead of a number.
> + */
> +static inline uint mk_int_int_mask(uint mask) {
> + return (1 << (7 - (mask/2)));
> +}

grumble. "uint" isn't a favoured "type". Please prefer to
use "unsigned int" if that's what is meant. Or maybe u32,
if that's more appropriate - and it probably is, as we're
dealing with device registers here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/