Re: [PATCH 1/6] lguest: host code tidyups

From: Rusty Russell
Date: Tue May 15 2007 - 19:32:54 EST


On Tue, 2007-05-15 at 21:47 +1000, Stephen Rothwell wrote:
> On Tue, 15 May 2007 21:42:35 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, 15 May 2007 11:17:07 +1000 Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> > > - on_each_cpu(adjust_pge, 0, 0, 1);
> > > + on_each_cpu(adjust_pge, (void *)0, 0, 1);
> >
> > Sorry? What ever happened to a simple NULL?
>
> Oh, I guess that is an explicit (numeric) 0 (of some type) caste to
> "void *" because of the prototype - rather than not passing anything?

Indeed. We really want to pass a bool, but on_each_cpu uses a void *.
Hence the clearest solution seemed "(void *)0" and "(void *)1" in the
callers.

Thanks,
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/