Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

From: Michael-Luke Jones
Date: Wed May 16 2007 - 06:20:30 EST


On 16 May 2007, at 10:41, Lennert Buytenhek wrote:
Making a driver work in both modes
of operation is generally not just an issue of adding a couple of
be32_to_cpu()s in the right places.

While this comment is technically correct, Christian's driver achieves endian agnostic operation with only 10 additional lines of code [1].

Thus, there is no reason to assume that gaining LE support will be a major issue.

Michael-Luke

[1] http://www.hohnstaedt.de/ixp_npe/0.3.1/ixp4xx_npe_driver-0.3.1.diff
Search in this file for "swap the payload of the SKB" (it's in mac_driver.c)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/