Re: [patch] Missing defines in asm-alpha/unistd.h!?

From: Oliver Falk
Date: Wed May 16 2007 - 10:17:38 EST


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/16/2007 03:10 PM, Oliver Falk wrote:
> On 05/16/2007 01:19 PM, Oliver Falk wrote:
>> On 05/16/2007 11:41 AM, Oliver Falk wrote:
>>> On 05/16/2007 10:57 AM, Oliver Falk wrote:
>>>> I believe this is missing... :-) I hope I understood NR_SYSCALLS
>>>> correctly and it's the number of defined syscals - as I added 20 of
>>>> them, I increased it by 20... Maybe someone can have a look if it's correct.
>>> [ ... ]
>>> Sorry, the patch was missing one hunk/file and also the tab stops where
>>> wrong. Attached a new working version.
>> But. The strange error that follows after patching:
>> ld -static -N -o .tmp_vmlinux1 -T arch/alpha/kernel/vmlinux.lds
>> arch/alpha/kernel/head.o init/built-in.o --start-group usr/built-in.o
>> arch/alpha/kernel/built-in.o arch/alpha/mm/built-in.o
>> arch/alpha/math-emu/built-in.o kernel/built-in.o mm/built-in.o
>> fs/built-in.o ipc/built-in.o security/built-in.o crypto/built-in.o
>> block/built-in.o lib/lib.a arch/alpha/lib/lib.a lib/built-in.o
>> arch/alpha/lib/built-in.o drivers/built-in.o sound/built-in.o
>> net/built-in.o --end-group
>> arch/alpha/kernel/built-in.o:(.data+0x2d60): undefined reference to
>> `sys_pselect6'
>> arch/alpha/kernel/built-in.o:(.data+0x2d68): undefined reference to
>> `sys_ppoll'
>
>> I don't understand this... Any clue(s)?
>
> Needed to replace sys_pselect6 and sys_ppoll with alpha_ni_syscall... If
> this is very correct way to fix it!? :-/
>
> Can someone please have a look and correct me!?

Sergey just told me, that this is wrong. Patch is fine, but we need
another. Please apply as well.

- -of
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFGSxFcxWN5Ge8lKUMRApQjAJwOFDVvTLyU1iUnGPYZOjDsgdQc+gCgln/Z
/l4a0VXPlCgjTfzQXklaC1g=
=VFix
-----END PGP SIGNATURE-----
--- linux-2.6.21.alpha/include/asm-alpha/thread_info.h.alpha_thread 2007-05-16 16:08:18.000000000 +0200
+++ linux-2.6.21.alpha/include/asm-alpha/thread_info.h 2007-05-16 16:08:07.000000000 +0200
@@ -76,12 +76,14 @@
#define TIF_UAC_NOFIX 7
#define TIF_UAC_SIGBUS 8
#define TIF_MEMDIE 9
+#define TIF_RESTORE_SIGMASK 11

#define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE)
#define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)
#define _TIF_SIGPENDING (1<<TIF_SIGPENDING)
#define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)
#define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
+#define _TIF_RESTORE_SIGMASK (1<<TIF_RESTORE_SIGMASK)

/* Work to do on interrupt/exception return. */
#define _TIF_WORK_MASK (_TIF_NOTIFY_RESUME \