Re: [patch] Missing defines in asm-alpha/unistd.h!?

From: Heiko Carstens
Date: Wed May 16 2007 - 15:40:20 EST


> >> arch/alpha/kernel/built-in.o:(.data+0x2d60): undefined reference to
> >> `sys_pselect6'
> >> arch/alpha/kernel/built-in.o:(.data+0x2d68): undefined reference to
> >> `sys_ppoll'
> >
> >> I don't understand this... Any clue(s)?
> >
> > Needed to replace sys_pselect6 and sys_ppoll with alpha_ni_syscall... If
> > this is very correct way to fix it!? :-/
> >
> > Can someone please have a look and correct me!?
>
> Sergey just told me, that this is wrong. Patch is fine, but we need
> another. Please apply as well.
>
> --- linux-2.6.21.alpha/include/asm-alpha/thread_info.h.alpha_thread 2007-05-16 16:08:18.000000000 +0200
> +++ linux-2.6.21.alpha/include/asm-alpha/thread_info.h 2007-05-16 16:08:07.000000000 +0200
> @@ -76,12 +76,14 @@
> #define TIF_UAC_NOFIX 7
> #define TIF_UAC_SIGBUS 8
> #define TIF_MEMDIE 9
> +#define TIF_RESTORE_SIGMASK 11
>
> #define _TIF_SYSCALL_TRACE (1<<TIF_SYSCALL_TRACE)
> #define _TIF_NOTIFY_RESUME (1<<TIF_NOTIFY_RESUME)
> #define _TIF_SIGPENDING (1<<TIF_SIGPENDING)
> #define _TIF_NEED_RESCHED (1<<TIF_NEED_RESCHED)
> #define _TIF_POLLING_NRFLAG (1<<TIF_POLLING_NRFLAG)
> +#define _TIF_RESTORE_SIGMASK (1<<TIF_RESTORE_SIGMASK)

If you want to wire up pselect6 and ppoll you need to add full
TIF_RESTORE_SIGMASK support. With your patches it compiles but is broken.
Search the git commits for "TIF_RESTORE_MASK" and see how this was
implemented on other architectures.
Also you should put the alpha maintainers on cc when sending such patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/