Re: [PATCH] Serial 8250: Handle saving the clear-on-read bits from theLSR and MSR

[Gene Heskett]

On Wednesday 16 May 2007, Corey Minyard wrote:
>Russell King wrote:
>> On Sun, May 06, 2007 at 12:58:25PM -0400, Gene Heskett wrote:
>>> [long message snipped]
>>>
>>> Thanks for your patience Corey.
>>
>> So, in one sentence or preferably one word, did Corey's patch cause a
>> regression?
>
>>From what Gene said, I think the final outcome is that this patch didn't
>seem to make any difference. It looks to me that the problems were
>elsewhere.
>
>So what's the state of this patch?
>
>Thanks,
>
>-corey

Gene here.  My impression was that this patch did help in that it appeared to 
clean up what was thought to be less than optimum code in that area.  There 
were a few times when it didn't seem to take quite as many kills and restarts 
of that ill-coded proprietary daemon to make things behave.

OTOH, I get the very strong impression there is another, more serious buglet 
someplace else that does a pretty good job of masking any black and white 
comparisons one might make about this patch.

Older code, as in 4 or 5 minor kernel versions back, appeared to work 
correctly, either on a serial port, or a usb port with a pl2303, if one could 
tolerate the miss-fires it did occasionally.  Now of course the pl2303 seems 
to be broken, both of the ones I have quit working at all with 2.6.21 final.

-- 
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
* |Rain| prepares for polygon soup
<|Rain|> sweet merciful crap, it works?
* |Rain| faints
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/