Re: [PATCH] recalc_sigpending_tsk fixes

[Roland McGrath]

> We already discussed this, this is not so important, but how about
> 
> 	void recalc_sigpending_and_wake(struct task_struct *t)
> 	{
> 		int was_pending = signal_pending(t);
> 
> 		if (recalc_sigpending_tsk(t) && !was_pending)
> 			signal_wake_up(t, 0);
> 	}
> 
> ?
> 
> This "was_pending" is more a documenation than a optimization.

I don't object, but I think another comment about the wakeup being
sometimes superfluous is enough, if anything.  


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/