Re: [PATCH 10/10] [HEADS UP] fbdev: Move arch-specific bits to their respective subdirectories

[Christoph Hellwig]

On Thu, May 17, 2007 at 05:33:48AM +0800, Antonino A. Daplas wrote:
> -#if defined(__sparc__) && !defined(__sparc_v9__)
> -	/* Should never get here, all fb drivers should have their own
> -	   mmap routines */
> -	return -EINVAL;
> -#else
> -	/* !sparc32... */
> +	if (fb_mmap_required())
> +		return -EINVAL;
> +

I don't like this bit.  It's just that all sparc frame buffers happen
to have a mmap method but there's nothing fundamentally arch specific
here.  You should be able to plug a pci video card into any linux
supported machine provided the fb driver does the full setup (which
only very few do in practice, but..)

So I'd just require drivers to have a fb_mmap method and make fb_mmap
the default one.  The page protection cleanup is still nice of course,
but it might make sense to give it a more generic name as it's not
really fb specific.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/