Re: [PATCH] ubi: kill homegrown endian macros

From: Artem Bityutskiy
Date: Thu May 17 2007 - 11:10:46 EST


On Thu, 2007-05-17 at 16:56 +0200, Christoph Hellwig wrote:
> On Thu, May 17, 2007 at 05:50:43PM +0300, Artem Bityutskiy wrote:
> > Christoph,
> >
> > On Thu, 2007-05-17 at 16:32 +0200, Christoph Hellwig wrote:
> > > Kill ubis homegrown endianess handling crap and replace it with
> > > the normal kernel endianess handling.
> >
> > Err,__be32 and the company are just sparse things, while I have compiler
> > checks with my struct ubi32_t and friends. JFFS2 also uses the same
> > technique. Why do you force me to rely on sparse instead instead of
> > compiler?
>
> Yes. Like all other code in the kernel aswell.

Andrew, may I please have your ack that I absolutely have to use __be32
instead of my own types since Christoph tends to provide no explanation
to his requests.

--
Best regards,
Artem Bityutskiy (ÐÐÑÑÑÐÐÐ ÐÑÑÑÐ)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/