Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv forMCP51/MCP55/MCP61

[Jan Engelhardt]

On May 17 2007 13:17, Andrew Morton wrote:
>> @@ -2115,7 +2115,7 @@ static void nv_fill_sg(struct ata_queued
>>  	WARN_ON(qc->__sg == NULL);
>>  	WARN_ON(qc->n_elem == 0 && qc->pad_len == 0);
>>  
>> -	prd = (struct ata_prd*)((u64)pp->prd + ATA_PRD_TBL_SZ*qc->tag);
>> +	prd = pp->prd + ATA_PRD_TBL_SZ*qc->tag;
>>  
>>  	idx = 0;
>>  	ata_for_each_sg(sg, qc) {
>
>hm, no.
>
>ugh, I dunno what's going on here and I think I'd prefer not to.  Can't
>we come up with some typesafe way of doing this without casting?
>
>Meanwhile, I'll switch the cast from u64 to long.

Maybe this?

	prd = (void *)pp->prd + ATA_PRD_TBL_SZ * qc->tag

Or...

	prd = pp->prd + (ATA_PRD_TBL_SZ * qc->tag) / sizeof(typeof(pp->prd));


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/