Re: [PATCH] fix kmalloc(0) in arch/ia64/pci/pci.c

From: KAMEZAWA Hiroyuki
Date: Thu May 17 2007 - 20:48:34 EST


On Thu, 17 May 2007 12:19:59 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > + if (!windows)
> > + goto out2;
> > controller->window = kmalloc_node(sizeof(*controller->window) * windows,
> > GFP_KERNEL, controller->node);
> > if (!controller->window)
> >
>
> This is a significant change in functionality. Can you please explain why
> it doesn't break things?
>
Sorry for long RTT. I found no problem on my machine, but....
I realized I misunderstood how kmalloc(0) works....sorry, please drop patch.

I'll ask a pci guy to fix this.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/