Re: [PATCH 01/14] kbuild: make modpost section warnings clearer

[Jan Engelhardt]

On May 18 2007 08:49, Sam Ravnborg wrote:
>index 113dc77..acd28ab 100644
>--- a/scripts/mod/modpost.c
>+++ b/scripts/mod/modpost.c
>@@ -885,29 +885,28 @@ static void warn_sec_mismatch(const char *modname, const char *fromsec,
> 		return;
> 
> 	if (before && after) {
>-		warn("%s - Section mismatch: reference to %s:%s from %s "
>-		     "between '%s' (at offset 0x%llx) and '%s'\n",
>-		     modname, secname, refsymname, fromsec,
>+		warn("%s(%s+0x%llx): Section mismatch: reference to %s:%s "
>+		     "(between '%s' and '%s')\n",
>+		     modname, fromsec, (long long)r.r_offset,
>+		     secname, refsymname,

%x always takes unsigned. %llx => (unsigned long long)r.r_offset.
Ditto below.

> 		     elf->strtab + before->st_name,
>-		     (long long)r.r_offset,
> 		     elf->strtab + after->st_name);
> 	} else if (before) {
>-		warn("%s - Section mismatch: reference to %s:%s from %s "
>-		     "after '%s' (at offset 0x%llx)\n",
>-		     modname, secname, refsymname, fromsec,
>-		     elf->strtab + before->st_name,
>-		     (long long)r.r_offset);
>+		warn("%s(%s+0x%llx): Section mismatch: reference to %s:%s "
>+		     "(after '%s')\n",
>+		     modname, fromsec, (long long)r.r_offset,
>+		     secname, refsymname,
>+		     elf->strtab + before->st_name);
[more occurences]


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/