Re: [PATCH] Fix a simple issue w.r.t mounting of containers

From: Paul Menage
Date: Fri May 18 2007 - 10:37:49 EST


Thanks. I've added that to my tree.

Paul

On 5/18/07, Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:


Fix containers mounting issue. With the current v9 patches if a container
hierarchy is mounted and then umounted. A second mount of the hierarchy
fails

Steps to reproduce the problem

1. mount -t container container /<mnt point>
2. umount /<mnt point>
3. mount -t container container /<mnt point>

Step 3 fails with -EBUSY. This is due to the fact that when we unmount,
in container_put_super(), we need to delete the current root from the roots
list.

The patch below fixes the issue


Signed-off-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>
---

kernel/container.c | 1 +
1 file changed, 1 insertion(+)

diff -puN kernel/container.c~fix-remount-issue kernel/container.c
--- linux-2.6.21-mm1/kernel/container.c~fix-remount-issue 2007-05-18 17:59:40.000000000 +0530
+++ linux-2.6.21-mm1-balbir/kernel/container.c 2007-05-18 18:00:02.000000000 +0530
@@ -574,6 +574,7 @@ static void container_put_super(struct s
ret = rebind_subsystems(root, 0);
BUG_ON(ret);

+ list_del(&root->root_list);
kfree(root);
mutex_unlock(&container_mutex);
}
_

--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/