Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference

From: Eugene Teo
Date: Sat May 19 2007 - 01:47:19 EST


Hi Randy,

Randy Dunlap wrote:
> On Sat, 19 May 2007 13:13:07 +0800 Eugene Teo wrote:
>
>> skb_peek() might return an empty list. skb should be checked before calling
>> llc_pdu_sn_hdr() with it.
>>
>> Spotted by the Coverity checker.
>>
>> Signed-off-by: Eugene Teo <eteo@xxxxxxxxxx>
[...]
>
> Networking patches need to be sent to the netdev@xxxxxxxxxxxxxxx
> mailing list (and lkml can be omitted IMHO).
>
> But... instead of doing the assignment and test in one swoop,
> we prefer:

Right, thanks for the reminder!

Eugene
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/