Re: RFC: kconfig select warnings bogus?

[Satyam Sharma]

On 5/20/07, Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote:
> Satyam Sharma wrote:
> > A combined patch for all of those on top of 22-rc2 (adding Signed-off-by's
> > for original authors too):
> >
> > Signed-off-by: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> > Signed-off-by: Satyam Sharma <ssatyam@xxxxxxxxxxxxxx>
>
> [...]
>
> > diff -ruNp a/drivers/input/keyboard/Kconfig
> > b/drivers/input/keyboard/Kconfig
> > --- a/drivers/input/keyboard/Kconfig    2007-05-20 04:11:55.000000000 +0530
> > +++ b/drivers/input/keyboard/Kconfig    2007-05-20 04:24:54.000000000 +0530
> > @@ -167,7 +167,6 @@ config KEYBOARD_AMIGA
> > config KEYBOARD_ATARI
> >     tristate "Atari keyboard"
> >     depends on ATARI
> > -    select ATARI_KBD_CORE
> >     help
> >       Say Y here if you are running Linux on any Atari and have a keyboard
> >       attached.
> > diff -ruNp a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
> > --- a/drivers/input/mouse/Kconfig    2007-05-20 04:11:55.000000000 +0530
> > +++ b/drivers/input/mouse/Kconfig    2007-05-20 04:25:09.000000000 +0530
> > @@ -179,7 +179,6 @@ config MOUSE_AMIGA
> > config MOUSE_ATARI
> >     tristate "Atari mouse"
> >     depends on ATARI
> > -    select ATARI_KBD_CORE
> >     help
> >       Say Y here if you have an Atari and want its native mouse
> >       supported by the kernel.
> > diff -ruNp a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
> > --- a/drivers/macintosh/Kconfig    2007-05-20 04:11:55.000000000 +0530
> > +++ b/drivers/macintosh/Kconfig    2007-05-20 04:18:57.000000000 +0530
> > @@ -113,7 +113,6 @@ config PMAC_SMU
> >
> > config PMAC_APM_EMU
> >     tristate "APM emulation"
> > -    select SYS_SUPPORTS_APM_EMULATION
> >     select APM_EMULATION
> >     depends on ADB_PMU && PM
> >
> > diff -ruNp a/drivers/net/Kconfig b/drivers/net/Kconfig
> > --- a/drivers/net/Kconfig    2007-05-20 04:11:56.000000000 +0530
> > +++ b/drivers/net/Kconfig    2007-05-20 04:22:15.000000000 +0530
> > @@ -2280,7 +2280,6 @@ config GFAR_NAPI
> > config UCC_GETH
> >     tristate "Freescale QE Gigabit Ethernet"
> >     depends on QUICC_ENGINE
> > -    select UCC_FAST
> >     help
> >       This driver supports the Gigabit Ethernet mode of the QUICC Engine,
> >       which is available on some Freescale SOCs.
>
> Adrian already commented on this.  Let me just add that these above
> changes are in so far *totally wrong* as they remove the "depends on
> XYZ" which is implied by "select XYZ".

Did you even try this patch?

Did you try to select UCC_GETH and see if UCC_FAST got
automatically selected or not?

Did you get any build problems (or bogus warnings, for that matter)?

Have you ever looked into arch/.../Kconfig's?

> Remember, "select" is like "depends on", just with the added twist that
> the 'make snafuconfig' scripts are instructed to (a) not hide the
> depending option from the user and (b) try to enable the dependency for
> the user if he tries to enable the depending option.

This is precisely what happens with this patch too.

Believe me, just go ahead and try it.

Report any errors, dissatisfaction, etc, if any.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/