Re: [PATCH (v2)] crypto: Remove pointless padlock module

From: Simon Arlott
Date: Sun May 20 2007 - 02:54:37 EST


On 20/05/07 04:15, Herbert Xu wrote:
On Sat, May 19, 2007 at 08:28:17PM +0100, Simon Arlott wrote:
It should be a bool that doesn't select anything, the AES and SHA modules will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7 instead of X86_32.

Having it as a tristate means that we don't have to duplicate the
dependencies and selects that each padlock algorithm would otherwise
do. So is there actually a problem with it being a tristate?

It has nothing to compile as a module, so M makes no sense. Each algorithm already selects CRYPTO_ALGAPI indirectly.

--
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/