Re: RFC: kconfig select warnings bogus?

From: Trent Piepho
Date: Sun May 20 2007 - 07:23:56 EST


On Sun, 20 May 2007, Stefan Richter wrote:
> Trent Piepho wrote:
> > config ATARI_KBD_CORE
> > bool
> > default y if KEYBOARD_ATARI
> > default y if MOUSE_ATARI
> >
> > Basically a line "config A \n select B" is transformed into "config B \n
> > default y if A". It's the same number of lines, they're just in a new place.
>
> Basically you replace
>
> A... depends on B
>
> by
>
> B... serves A
>
> The latter variant is a pain to maintain. Dependencies change over
> time, therefore we should note the dependency always at the dependent
> option, not at the serving option.

The problem is that "B" will not exist on some architectures. If you put the
dependency with "A", the dependency still exists when "B" is gone. If the
dependency is with "B", it nicely goes away when "B" is gone.

> Iterating upwards and downwards the dependency graph is the duty of
> "make snafuconfig", not of the maintainers.
>
> Besides, the "serves" form cannot stand in for constructs like
>
> A... depends on (B && C) || D

This is for replacing "select" lines, which can't look like that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/