Re: [PATCH] signalfd: retrieve multiple signals with one read() call

[Davide Libenzi]

On Sun, 20 May 2007, Andrew Morton wrote:

> If 'count' is not a multiple of sizeof(struct signalfd_siginfo)), the read()
> will return the next smallest multiple of `count'.
> 
> That is, unless `count' happens to be less than 1*sizeof(struct
> signalfd_siginfo)), in which case we return -EINVAL.
> 
> This seems inconsistent.

I think it fits the rule "buffer must be big enough for at least one sigingo".
We use the special return 0; as indicator that the process we were 
monitoring signals, detached the sighand.



> Also, I'm desperately hunting for the place where we zero out that local
> siginfo_t, and I ain't finding it.  Someone please convince me that we're
> not leaking bits of kernel memory out to userspace in that thing.

Hmm, __clear_user()?


- Davide


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/