Re: [PATCH] lockdep: lock contention tracking

From: hui
Date: Mon May 21 2007 - 02:42:22 EST


On Mon, May 21, 2007 at 08:08:28AM +0200, Ingo Molnar wrote:
> To me it appears Peter's stuff is already a pretty complete solution on
> its own, and it's a whole lot simpler (and less duplicative) than your
> lockstat patch. Could you list the specific items/features that you
> think Peter's stuff doesnt have?

First of all, this isn't an either/or kind of thing nor should it be thought
of in that way.

Precise file/function/line placement for one thing. My patch is specifically
for -rt which does checks that Peter's doesn't and is needed to characterize
-rt better. My stuff is potentially more extensible since I have other ideas
for it that really are outside of the lockdep logic currently. These can be
unified, but not so that one overrides the intended features of other. That's
why I was hessitant to completely unify with lockdep in the manner you
suggested.

bill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/