Re: [PATCH]serial: make early_uart to use early_prarm instead of console_initcall

From: Bjorn Helgaas
Date: Mon May 21 2007 - 12:53:37 EST


On Monday 21 May 2007 12:56:37 am Yinghai Lu wrote:
> Bjorn,
> I can not find fixmap.h for ia64.....hope you can use ioremap instead,
> then we can create one dummy fixmap.h in include/asm-ia64

ia64 ioremap should work early enough, so it doesn't have fixmap.
Seems like in this case, maybe bt_ioremap() would be more
appropriate than fixmap, since there's no requirement that
virtual address be known at compile-time.

> [PATCH]serial: make early_uart to use early_prarm instead of console_initcall

s/prarm/param/

> new command line will be
>
> earlycon=uart,io,0x3f8,9600n8
> earlycon=uart,io,0x3f8,9600n8 console=tty0
> earlycon=uart,mmio,0xff5e0000,115200n8

Why do we have to have a new "earlycon" argument? Why can't we just
parse "console=uart" early?

BTW, if you want to convert it from "console=uart" to "console=8250",
as part of this cleanup, I think that would be OK. Just make it a
separate patch and don't forget to change drivers/firmware/pcdp.c and
Documentation/kernel-parameters.txt at the same time.

Bjorn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/