Re: any value to "NORET_TYPE" macro?

[Robert P. J. Day]

On Tue, 22 May 2007, John Anthony Kazos Jr. wrote:

> >   given that:
> >
> > $ grep -r "define.*NORET_TYPE" *
> > include/linux/ext4_fs.h:# define NORET_TYPE    /**/
> > include/linux/linkage.h:#define NORET_TYPE    /**/
> > include/linux/ext3_fs.h:# define NORET_TYPE    /**/
> > $
> >
> > is there any obvious value to the 30 or so uses of that macro
> > sprinkled throughout the tree?
>
> Since it evaluates to absolutely empty code during pre-processing,
> there is no obvious value. The question is whether there is some odd
> hackish non-obvious value, I'd expect. (I'd also expect that to be
> another "no".)
>
> If something that evaluates to nothingness ("There was nothing
> left...not even a hole!") actually does anything, then somebody in
> the standards-compilers-users pipeline needs to be violently beaten
> for stupidity.


actually, one of the folks on the KJ list found this:

  http://www.ussg.iu.edu/hypermail/linux/kernel/9605/1957.html

which speaks thusly:

...
-#if __GNUC__ < 2 || (__GNUC__ == 2 && __GNUC_MINOR__ < 5)
-# define NORET_TYPE __volatile__
-# define ATTRIB_NORET /**/
-# define NORET_AND /**/
-#else
# define NORET_TYPE /**/
# define ATTRIB_NORET __attribute__((noreturn))
# define NORET_AND noreturn,
-#endif
...

  so it looks like a thoroughly obsolete macro which can be tossed.
i'll make the patch and test it.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/