Re: use mutex instead of semaphore in RocketPort driver

[Jiri Slaby]

Simon Arlott napsal(a):
> On 22/05/07 21:06, Matthias Kaehlcke wrote:
>> would the following resolve the problem?
>>
>> if(mutex_lock_interruptible(&info->write_mtx))         return
>> -ERESTARTSYS
>>
>> thanks for your comments
>>
> 
> No. At least one user of tty_operations/tty_driver's write function
> doesn't check the return value so it would never be retried, mutex_lock
> should be used instead.

Who? There are some drivers that returns ERESTARTSYS from write function.

regards,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
 B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/