Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code

From: Stefan Richter
Date: Wed May 23 2007 - 02:34:12 EST


Dan Dennedy wrote:
> On Sunday 20 May 2007 08:28, Stefan Richter wrote:
>> maybe we should change
...
>> struct raw1394_cycle_timer {
[to consist of two u64 to get same alignment on all architectures]
...
>> before a libraw1394 with get-cycle-timer support is released.
>> Shall I prepare according patches for raw1394 and libraw1394?
>
> This seems like a good idea, and I have forwarded it to the ffado (formerly
> freebob) developers, specifically Pieter Palmers--the submitter of
> raw1394_read_cycle_timer--to get his feedback.

I'll post the patches tonight to see how it will look like. Even though
I already posted the kernel-only patch which adjusts
raw1394_iso_packets32 per architecture, the 2x u64 variant may overall
be nicer: a) it eliminates the need for raw1394_cycle_timer32, b) the
get-cycle-timer ABI still has to be duplicated in Juju, and Juju so far
did not require different struct types for 32bit compatibility ioctls.
--
Stefan Richter
-=====-=-=== -=-= =-===
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/