Re: [PATCH] CDROM: replace jiffies busyloop with msleep

[Ingo Molnar]

* Rene Herman <rene.herman@xxxxxxxxx> wrote:

> The trouble there is that unless you poll the bloody thing like mad 
> too much of the Q subchannels passes below you and you need a huge 
> number of retries to get anything out of it. I noticed when I started 
> adding audio bits that the driver took full seconds to complete some 
> audio requests while the old driver was snappy in that regard. When I 
> replaced our sleeping loop with a busy-wait same as the original the 
> snappyness returned and moreover, reading the TOC from the CD went 
> from something close to a minute to approximately a second. Thought 
> that minute was just because I was dealing with an old junk 1-speed 
> drive...

ouch ...

then i guess the right approach is to not use jiffies but to use a 
calculated number of udelay(10) calls or so.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/