Re: [PATCH] CDROM: replace jiffies busyloop with msleep

From: Rene Herman
Date: Wed May 23 2007 - 15:41:26 EST


On 05/23/2007 09:34 PM, Alan Cox wrote:

driver was snappy in that regard. When I replaced our sleeping loop with a busy-wait same as the original the snappyness returned and moreover, reading the TOC from the CD went from something close to a minute to approximately a second. Thought that minute was just because I was dealing with an old junk 1-speed drive...

It happens. If you want to be fairer you can check need_resched in the
loop so that you still share the CPU fairly with other users.

Thanks for the tip -- I'll do this.

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/