Re: [RFC PATCH] PCI MMCONFIG: add validation against ACPI motherboard resources

From: Jesse Barnes
Date: Wed May 23 2007 - 19:11:46 EST


On Wednesday, May 23, 2007 4:04 pm David Miller wrote:
> From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 23 May 2007 15:16:23 -0700 (PDT)
>
> > That crap should be seen for the crap it is! Dammit, how hard can
> > it be to just admit that mmconfig isn't that great?
>
> I knew mmconfig was broken conceptually the first time I started
> seeing write posting "bug fixes" for it that would do a read back
> from PCI config space via mmconfig to post the write, which of course
> has potential side-effects on the device and is absolutely illegal if
> the write just performed put the device into a PM state or whatever.

I've actually seen that specific form of posted write flushing cause
crashes on some machines, so yes, it sucks.

Unfortunately, I don't think we have any other way of getting at
extended config space on x86, unless EFI provides methods or something,
but I'm not sure that would be an improvement...

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/