Re: [PATCH 1/1] hotplug cpu: migrate a task within its cpuset

From: Ingo Molnar
Date: Thu May 24 2007 - 03:56:33 EST



* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > When a cpu is disabled, move_task_off_dead_cpu() is called for tasks
> > that have been running on that cpu.
>
> So I still have these three patches in the pending queue but I was
> rather hoping that the scheduler, sched-domains and cpuset people
> could take a look at them, please.
>
> They hit sched.c and cpuset.c mainly, and they might trash Ingo's CFS
> patch (I haven't checked).

The patch looks good to me. It applies cleanly ontop of CFS and it
builds and boots fine with and without CONFIG_CPU_HOTPLUG (although i
havent tried to explicitly stress the codepath in question). We are a
bit paranoid in this codepath but it's not performance-critical
normally.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/