Re: [PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events)
From: Ingo Molnar
Date: Thu May 24 2007 - 05:55:29 EST
* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 24 May 2007 09:58:35 +0200 Ingo Molnar <mingo@xxxxxxx> wrote:
>
> >
> > * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > Well OK. But vdso-print-fatal-signals.patch is designated
> > > not-for-mainline anyway.
> >
> > btw., why?
>
> err, because that's what I decided a year ago. I wonder why ;)
>
> Perhaps because of the DoS thing, but it has a /proc knob and defaults
> to off, so it should be OK.
yeah. There's also a boot option. To address the DoS angle, should i
make it optionally printk_ratelimit() perhaps? (although often the
messages come in streams and skipping a message can be annoying)
> > It's very, very useful to distro, early-boot-userspace and glibc
> > development. The only add-on change should be to not print SIGKILL
> > events. Otherwise it's very much a keeper. Hm?
>
> <promotes it>
thanks :-)
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/