Re: [PATCH 4/6] RTC: Ratelimit "lost interrupts" message

From: Ben Collins
Date: Thu May 24 2007 - 16:56:43 EST


On Thu, 2007-05-24 at 13:48 -0700, Andrew Morton wrote:
> On Wed, 23 May 2007 18:23:06 -0400
> Ben Collins <bcollins@xxxxxxxxxx> wrote:
>
> > Signed-off-by: Ben Collins <bcollins@xxxxxxxxxx>
> > ---
> > drivers/char/rtc.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
> > index 20380a2..22cf7aa 100644
> > --- a/drivers/char/rtc.c
> > +++ b/drivers/char/rtc.c
> > @@ -1159,7 +1159,8 @@ static void rtc_dropped_irq(unsigned long data)
> >
> > spin_unlock_irq(&rtc_lock);
> >
> > - printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq);
> > + if (printk_ratelimit())
> > + printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq);
> >
>
> Presumably someone is getting a lot of these messages.
>
> Do we know why? Is there something which needs fixing here?

I got it a lot when using any sort of virtualization on my Core2Duo
(kvm, vmware, qemu). Just a big spew. Honestly, I was getting this with
2.6.20, and haven't tested again with latest kernel.

--
Ubuntu : http://www.ubuntu.com/
Linux1394: http://wiki.linux1394.org/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/