Re: 2.6.22-rc2-mm1

[Andrew Morton]

On Thu, 24 May 2007 15:35:45 -0700 (PDT)
Christoph Lameter <clameter@xxxxxxx> wrote:

> > This is pretty-printing.  and creature-feep.
> > But lib/hexdump.c can probably do this if we add a "prefix/tag" string
> > parameter to it.
> > 
> > Hugh D. wants it to print 32-bit quantities, not just bytes.
> > Yet another parameter.
> > 
> > I'll look into these unless Christoph et al does so first.
> 
> I'd appreciate if you could do this. I just added a call to the function 
> in hexdump.c and got this ugly output. I think we need
> 
> 1. byte output

yup.  Obviously a suitable implementation would then permit 1-byte,2-byte,3-byte,etc
output.

> 2. A way to specify the width of the description.

Maybe not.  The caller could just ensure that the preamble strings are
all of the same length:

	hexdump("Bytes   ", ...);
	hexdump("Object  ", ...);
	hexdump("Redzone ", ...);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/