Re: [patch 6/7] ps3: ROM Storage Driver

From: Benjamin Herrenschmidt
Date: Sat May 26 2007 - 18:19:30 EST


On Sat, 2007-05-26 at 10:52 +0200, Geert Uytterhoeven wrote:
> On Sat, 26 May 2007, Benjamin Herrenschmidt wrote:
> > On Fri, 2007-05-25 at 13:24 +0200, Olaf Hering wrote:
> > > On Fri, May 25, Geert.Uytterhoeven@xxxxxxxxxxx wrote:
> > >
> > > > +++ b/drivers/scsi/ps3rom.c
> > >
> > > > + kaddr = kmap_atomic(sgpnt->page, KM_USER0);
> > >
> > > linux/highmem.h is not included to get the kmap_* prototypes.
> >
> > Beside, I don't see the point of using kmap on ppc64...
>
> So what should I use instead?

you don't need to map ... the linear mapping is there.... page_address()
should just work. But then, kmap will resolve to just that anyway so I
suppose it doesn't matter.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/