Re: [PATCH] merge dst_discard in & out into one, this decrementsthe vmlinux image by 21 bytes under i386 arch.

[Jan Engelhardt]

On May 28 2007 10:41, rae l wrote:
>
> diff --git a/net/core/dst.c b/net/core/dst.c
> index 764bccb..daa0439 100644
> --- a/net/core/dst.c
> +++ b/net/core/dst.c
> @@ -111,17 +111,14 @@ out:
>      spin_unlock(&dst_lock);
> }
>
> -static int dst_discard_in(struct sk_buff *skb)
> +static int dst_discard(struct sk_buff *skb)
> {
> kfree_skb(skb);
> return 0;
> }
>
> -static int dst_discard_out(struct sk_buff *skb)
> -{
> -       kfree_skb(skb);
> -       return 0;
> -}
> +#define dst_discard_in dst_discard
> +#define dst_discard_out        dst_discard

Uhm, just replace every invocation of dst_discard_in/_out() directly
by dst_discard ... don't add macros for that.


>
> void * dst_alloc(struct dst_ops * ops)
> {
>
>

	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/