Re: [PATCH 1/7] cxgb3 - Fix SGE page management

[Jeff Garzik]

divy@xxxxxxxxxxx wrote:
> From: Divy Le Ray <divy@xxxxxxxxxxx>
>
> Streamline page management on RX.
> Fix dma mappings.
>
> Signed-off-by: Divy Le Ray <divy@xxxxxxxxxxx>

NAK #1:  "streamline" is not a bug-fixes-only change, which is the only 
type of change appropriate for 2.6.22-rc.

NAK #2:  You should use the page_address(page) accessor rather than 
creating a struct member in the same struct as your page, solely to 
contain the virtual address.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/