Re: [PATCH] AFS: Implement file locking [try #2]

[J. Bruce Fields]

On Wed, May 30, 2007 at 09:35:32AM +0100, David Howells wrote:
> J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote:
> 
> > --without having tried to understand how they're actually used, these
> > data structures (like the pending_locks and granted_locks lists) seem to
> > duplicate stuff that's already kept in fs/locks.c.  Is there a reason
> > they're required?
> 
> Yes.  I need to get the server lock first, before going to the VFS locking
> routines.

That doesn't really answer the question.  The NFS client has similar
requirements, but it doesn't have to duplicate the per-inode lists of
granted locks, for example.

> The VFS routines as they stand aren't particularly useful, and they
> permit things that AFS doesn't support (such as lock upgrading).

Sure.  But handling those things is just a matter of checking for a few
special cases and making sure they're rejected before calling the posix
routines.

--b.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/