Re: [PATCH 1/3] hexdump: more output formatting

[Jesper Juhl]

On 31/05/07, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> Jesper Juhl wrote:
> > On 30/05/07, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> >> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> >>
> >
> > Some friendly nitpicking below :-)
> >
> >> Add a prefix string parameter.  Callers are responsible for any
> >> string length/alignment that they want to see in the output.  I.e.,
> >> callers should pad strings to achieve alignment if they want that.
> >>
> >> Add rowsize parameter.  This is the number of raw data bytes
> >> to be printed per line.  Must be 16 or 32.
> >>
> >> Add a group_size parameter.  This allows callers to dump values
> >
> > One is called "rowsize" the other "group_size". How about consistent
> > naming; either "row_size" and "group_size" or "rowsize" and
> > "groupsize" ?
>
> Done.  but please don't add that to CodingStyle.
Hehe, don't worry, I won't ;-)
I just spotted it when reading the patch and thought I'd point it out :)

--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/